Capture and handle properly every call to JSArray that read or writes elements via a native call

Capture and handle properly every call to JSArray that read or writes elements via a native call

R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25215

[karlklose, 2013-07-15 14:24:52]

LGTM.

https://chromiumcodereview.appspot.com/18429011/diff/1/sdk/lib/_internal/comp...
File
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart
(right):

https://chromiumcodereview.appspot.com/18429011/diff/1/sdk/lib/_internal/comp...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:606:
* concrete implmentation of lists for the selected backend.
'implmentation' -> 'implementation'

https://chromiumcodereview.appspot.com/18429011/diff/1/sdk/lib/_internal/comp...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1317:
Link<Element> parameters = function.functionSignature.requiredParameters;
Extract a small helper to share with lines 1301/2 and 1308/09.

[polux, 2013-07-19 13:35:26]

https://chromiumcodereview.appspot.com/18429011/diff/1/sdk/lib/_internal/comp...
File
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart
(right):

https://chromiumcodereview.appspot.com/18429011/diff/1/sdk/lib/_internal/comp...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:606:
* concrete implmentation of lists for the selected backend.
On 2013/07/15 14:24:52, karlklose wrote:
> 'implmentation' -> 'implementation'

Done.

https://chromiumcodereview.appspot.com/18429011/diff/1/sdk/lib/_internal/comp...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1317:
Link<Element> parameters = function.functionSignature.requiredParameters;
On 2013/07/15 14:24:52, karlklose wrote:
> Extract a small helper to share with lines 1301/2 and 1308/09.

I'm not sure how to to that because in one case I need later what would then
become a local variable of the helper (parameters). I could do a function that
returns the parameter or null if there is an error bu then checking for null
would take one additional line so I wouldn't gain anything.

I'm submitting as is but please comment there if I missed something and I'll
create another CL.

[polux, 2013-07-19 13:56:43]

Committed patchset #2 manually as r25215 (presubmit successful).