Issue 18428003: Fix pub errorgroup and analyzer errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18428003: Fix pub errorgroup and analyzer errors. (Closed)

Created:
7 years, 5 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix pub errorgroup and analyzer errors. Errorgroup now works as it used to, using an old-style asBroadcastStream instead of a proper broadcast controller, because that's what the tests are testing for. Analyzer was complaining about code that should have been deleted. Now it is. Committed: https://code.google.com/p/dart/source/detail?r=24778

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/error_group.dart	View		3 chunks	+11 lines, -4 lines	0 comments	Download
	M	tests/lib/async/stream_state_helper.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #1 manually as r24778 (presubmit successful).

7 years, 5 months ago (2013-07-04 14:13:43 UTC) #2

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages