Issue 184273005: VM: Fix bug in aliasing computation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 184273005: VM: Fix bug in aliasing computation. (Closed)

Created:
6 years, 9 months ago by Florian Schneider

Modified:
6 years, 9 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

VM: Fix bug in aliasing computation. Values flowing into arrays were not correctly computed as aliased. TEST=tests/language/vm/load_to_load_forwarding_vm_test.dart R=srdjan@google.com, vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=33334

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	tests/language/vm/load_to_load_forwarding_vm_test.dart	View		2 chunks	+22 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Vyacheslav Egorov (Google)

LGTM! May I suggest going through the other IR instructions looking for stores?

6 years, 9 months ago (2014-03-05 17:43:10 UTC) #3

Florian Schneider

6 years, 9 months ago (2014-03-05 17:58:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r33334 (presubmit successful).