Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 18420007: pkg/unittest: cleanup to InteractiveHtmlConfiguration (Closed)

Created:
7 years, 5 months ago by kevmoo-old
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/unittest: cleanup to InteractiveHtmlConfiguration fixed dart2js R=gram@google.com Committed: https://code.google.com/p/dart/source/detail?r=24708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -28 lines) Patch
M pkg/unittest/lib/interactive_html_config.dart View 16 chunks +36 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo-old
Dart2js output uses postMessage a lot. These were being intercepted by parent/child communication, causing errors ...
7 years, 5 months ago (2013-07-02 18:38:16 UTC) #1
gram
lgtm
7 years, 5 months ago (2013-07-02 22:28:43 UTC) #2
kevmoo-old
7 years, 5 months ago (2013-07-02 22:32:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24708 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698