Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 18400002: Roll back "Use package:stack_trace in unittest." (Closed)

Created:
7 years, 5 months ago by nweiz
Modified:
7 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, gram
Visibility:
Public.

Description

Roll back "Use package:stack_trace in unittest." This reverts r24652, r24659, and r24661. r24652 triggered a crashing bug in all the Dartium tests, so it's being reverted until that bug is fixed. BUG=11649 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=24669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -107 lines) Patch
M pkg/unittest/lib/compact_vm_config.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/unittest/lib/html_config.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/unittest/lib/html_enhanced_config.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/unittest/lib/interactive_html_config.dart View 4 chunks +6 lines, -23 lines 0 comments Download
M pkg/unittest/lib/src/config.dart View 5 chunks +22 lines, -16 lines 0 comments Download
M pkg/unittest/lib/src/test_case.dart View 6 chunks +12 lines, -7 lines 0 comments Download
M pkg/unittest/lib/src/utils.dart View 1 chunk +0 lines, -21 lines 0 comments Download
M pkg/unittest/lib/unittest.dart View 5 chunks +76 lines, -24 lines 0 comments Download
M pkg/unittest/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/command_line_config.dart View 2 chunks +90 lines, -3 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download
M utils/testrunner/standard_test_runner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 5 months ago (2013-07-01 22:02:17 UTC) #1
siva
lgtm
7 years, 5 months ago (2013-07-01 22:40:48 UTC) #2
nweiz
7 years, 5 months ago (2013-07-01 23:12:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24669 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698