Issue 183993003: Revert commits r33138, r33135, and r33134.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183993003: Revert commits r33138, r33135, and r33134. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert commits r33138, r33135, and r33134. r33134 introduced bugs that require a reasonably substantial refactor, and the other two built on top of it. R=rnystrom@google.com TBR Committed: https://code.google.com/p/dart/source/detail?r=33144

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1347 lines, -1564 lines)			Patch
D	pkg/barback/lib/src/asset_node_set.dart	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	pkg/barback/lib/src/group_runner.dart	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/phase_forwarder.dart	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	pkg/barback/lib/src/phase_input.dart	View	7 chunks	+48 lines, -55 lines	0 comments	Download
M	pkg/barback/lib/src/phase_output.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/pubspec.yaml	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/barback/test/package_graph/add_remove_transform_test.dart	View	6 chunks	+21 lines, -102 lines	0 comments	Download
M	pkg/barback/test/package_graph/errors_test.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/barback/test/package_graph/get_all_assets_test.dart	View	1 chunk	+11 lines, -11 lines	0 comments	Download
M	pkg/barback/test/package_graph/group_test.dart	View	10 chunks	+63 lines, -43 lines	0 comments	Download
M	pkg/barback/test/package_graph/lazy_transformer_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	pkg/barback/test/package_graph/transform/concurrency_test.dart	View	1 chunk	+0 lines, -473 lines	0 comments	Download
D	pkg/barback/test/package_graph/transform/cross_package_test.dart	View	1 chunk	+0 lines, -226 lines	0 comments	Download
D	pkg/barback/test/package_graph/transform/pass_through_test.dart	View	1 chunk	+0 lines, -273 lines	0 comments	Download
D	pkg/barback/test/package_graph/transform/transform_test.dart	View	1 chunk	+0 lines, -344 lines	0 comments	Download
A	pkg/barback/test/package_graph/transform_test.dart	View	1 chunk	+1179 lines, -0 lines	0 comments	Download
M	pkg/barback/test/utils.dart	View	2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 manually as r33144 (presubmit successful).

6 years, 9 months ago (2014-02-28 01:14:32 UTC) #2

Message was sent while issue was closed.

lgtm.

Expand Messages | Collapse Messages