Make pub deploy copy over interop.js.

Make pub deploy copy over interop.js.

BUG=https://code.google.com/p/dart/issues/detail?id=11224
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24831

[nweiz, 2013-07-08 20:29:58]

A couple comments, otherwise lgtm.

https://codereview.chromium.org/18399004/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/command/deploy.dart (right):

https://codereview.chromium.org/18399004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/command/deploy.dart:111:
sourceLengths.add("package:browser/dart.js".length);
This is redundant, since "browser/interop.js" is the longer string.

https://codereview.chromium.org/18399004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/command/deploy.dart:128: void
_maybeAddJsFile(String directory, String name) {
I like the name "_maybeAddBrowserJs" a little better, since the function is
explicitly tied to the browser package.

https://codereview.chromium.org/18399004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/command/deploy.dart:140: bool get _shouldAddDartJs
{
Rename to _shouldAddBrowserJs, update the doc accordingly.

[Bob Nystrom, 2013-07-08 22:43:03]

Thanks!

https://codereview.chromium.org/18399004/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/command/deploy.dart (right):

https://codereview.chromium.org/18399004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/command/deploy.dart:111:
sourceLengths.add("package:browser/dart.js".length);
On 2013/07/08 20:29:58, nweiz wrote:
> This is redundant, since "browser/interop.js" is the longer string.

Done.

https://codereview.chromium.org/18399004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/command/deploy.dart:128: void
_maybeAddJsFile(String directory, String name) {
On 2013/07/08 20:29:58, nweiz wrote:
> I like the name "_maybeAddBrowserJs" a little better, since the function is
> explicitly tied to the browser package.

Done.

https://codereview.chromium.org/18399004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/command/deploy.dart:140: bool get _shouldAddDartJs
{
On 2013/07/08 20:29:58, nweiz wrote:
> Rename to _shouldAddBrowserJs, update the doc accordingly.

Done.

[Bob Nystrom, 2013-07-08 22:43:47]

Committed patchset #2 manually as r24831 (presubmit successful).