Faster _Smi.toString()

Faster _Smi.toString()

Add tests.

R=ajohnsen@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33416

[Anders Johnsen, 2014-03-05 14:41:33]

LGTM, with comments and Srdjan's approval.

Can you upload the list version as well, to get perf numbers.

https://codereview.chromium.org/183973030/diff/20001/runtime/lib/integers.dart
File runtime/lib/integers.dart (right):

https://codereview.chromium.org/183973030/diff/20001/runtime/lib/integers.dar...
runtime/lib/integers.dart:263: static const digits = const [
better name?

Also, all of this new stuff should be private, so I can't say 

  5.digits

[srdjan, 2014-03-05 17:40:45]

Also what Anders said. Please provide some performance numbers.

https://codereview.chromium.org/183973030/diff/20001/runtime/lib/integers.dart
File runtime/lib/integers.dart (right):

https://codereview.chromium.org/183973030/diff/20001/runtime/lib/integers.dar...
runtime/lib/integers.dart:330: int length = this < 10 ? 1 : this < 100 ? 2 :
positiveBase10Length(this);
Please use parentheses.

[Lasse Reichstein Nielsen, 2014-03-06 12:25:37]

https://codereview.chromium.org/183973030/diff/20001/runtime/lib/integers.dart
File runtime/lib/integers.dart (right):

https://codereview.chromium.org/183973030/diff/20001/runtime/lib/integers.dar...
runtime/lib/integers.dart:263: static const digits = const [
-> digitTable.

No *need* for private, it's all static and inside a private class.
I've made them private anyway, because it really doesn't matter.

https://codereview.chromium.org/183973030/diff/20001/runtime/lib/integers.dar...
runtime/lib/integers.dart:330: int length = this < 10 ? 1 : this < 100 ? 2 :
positiveBase10Length(this);
Rewritten.

[srdjan, 2014-03-06 17:57:13]

LGTM, good performance improvement.

https://codereview.chromium.org/183973030/diff/20001/runtime/lib/integers.dart
File runtime/lib/integers.dart (right):

https://codereview.chromium.org/183973030/diff/20001/runtime/lib/integers.dar...
runtime/lib/integers.dart:263: static const digits = const [
On 2014/03/06 12:25:37, Lasse Reichstein Nielsen wrote:
> -> digitTable.
> 
> No *need* for private, it's all static and inside a private class.
> I've made them private anyway, because it really doesn't matter.

All public members of a private class are accessible within the same library
AFAIK. By making them public you show intent that they should be used outside
the class as well. That is not the case here. Thanks for making them private.

[Lasse Reichstein Nielsen, 2014-03-07 09:29:20]

https://codereview.chromium.org/183973030/diff/20001/runtime/lib/integers.dart
File runtime/lib/integers.dart (right):

https://codereview.chromium.org/183973030/diff/20001/runtime/lib/integers.dar...
runtime/lib/integers.dart:263: static const digits = const [
On 2014/03/06 17:57:14, srdjan wrote:

> All public members of a private class are accessible within the same library
> AFAIK. By making them public you show intent that they should be used outside
> the class as well. That is not the case here. 

Private members are also accessible with the same library. Making them private
really only shows intent that they shouldn't be used from outside the library,
which they already can't.
The advantage of being private is that you can see locally that they are not
visible outside the library, without having to refer to the class name. Which,
arguably, is an advantage.

[Lasse Reichstein Nielsen, 2014-03-07 09:32:00]

Committed patchset #4 manually as r33416 (presubmit successful).