Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183923026: Inline of Float64x2 operations round 1 (Closed)

Created:
6 years, 9 months ago by Cutch
Modified:
6 years, 9 months ago
Reviewers:
zra, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Inline of Float64x2 operations round 1 BUG= R=srdjan@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=33459

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1295 lines, -2 lines) Patch
M runtime/vm/assembler_ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32_test.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_ia32.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_x64.cc View 1 chunk +8 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 9 chunks +168 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 2 chunks +40 lines, -0 lines 0 comments Download
M runtime/vm/il_printer.cc View 2 chunks +45 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 7 chunks +358 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 chunks +213 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +151 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 chunks +65 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +149 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Cutch
+zra for ARM bits.
6 years, 9 months ago (2014-03-04 16:59:37 UTC) #1
zra
arm/mips lgtm with comments. https://codereview.chromium.org/183923026/diff/1/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/183923026/diff/1/runtime/vm/intermediate_language_arm.cc#newcode3869 runtime/vm/intermediate_language_arm.cc:3869: // Low (< Q7) Q ...
6 years, 9 months ago (2014-03-04 17:43:50 UTC) #2
srdjan
LGTM after adding assembler tests.
6 years, 9 months ago (2014-03-04 18:44:35 UTC) #3
Cutch
Assembler tests added for IA32 and X64. https://codereview.chromium.org/183923026/diff/1/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/183923026/diff/1/runtime/vm/intermediate_language_arm.cc#newcode3869 runtime/vm/intermediate_language_arm.cc:3869: // Low ...
6 years, 9 months ago (2014-03-07 21:41:28 UTC) #4
Cutch
6 years, 9 months ago (2014-03-07 21:44:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r33459 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698