Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 183853022: Hoist hasReflectedType and reflectedType from ClassMirror to TypeMirror. (Closed)

Created:
6 years, 9 months ago by rmacnak
Modified:
6 years, 9 months ago
Reviewers:
regis, gbracha
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Hoist hasReflectedType and reflectedType from ClassMirror to TypeMirror. R=gbracha@google.com, regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=33291

Patch Set 1 #

Patch Set 2 : version the tests #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -38 lines) Patch
M runtime/lib/mirrors_impl.dart View 1 2 3 chunks +18 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 2 2 chunks +13 lines, -12 lines 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A + tests/lib/mirrors/reflected_type_classes_test.dart View 1 2 2 chunks +3 lines, -25 lines 0 comments Download
A tests/lib/mirrors/reflected_type_function_type_test.dart View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A tests/lib/mirrors/reflected_type_helper.dart View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A tests/lib/mirrors/reflected_type_special_types_test.dart View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A tests/lib/mirrors/reflected_type_typedefs_test.dart View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A tests/lib/mirrors/reflected_type_typevars_test.dart View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmacnak
6 years, 9 months ago (2014-03-04 00:45:13 UTC) #1
gbracha
tests and API lgtm.
6 years, 9 months ago (2014-03-04 01:01:59 UTC) #2
regis
LGTM https://codereview.chromium.org/183853022/diff/20001/tests/lib/mirrors/reflected_type_function_type_test.dart File tests/lib/mirrors/reflected_type_function_type_test.dart (right): https://codereview.chromium.org/183853022/diff/20001/tests/lib/mirrors/reflected_type_function_type_test.dart#newcode1 tests/lib/mirrors/reflected_type_function_type_test.dart:1: // Copyright (c) 2013, the Dart project authors. ...
6 years, 9 months ago (2014-03-04 18:17:18 UTC) #3
rmacnak
Oh, yes, Happy New Year!
6 years, 9 months ago (2014-03-04 18:57:20 UTC) #4
rmacnak
6 years, 9 months ago (2014-03-04 19:01:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r33291 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698