Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 183763026: Allow a single translation to be from multiple differently-named sources (Closed)

Created:
6 years, 9 months ago by Alan Knight
Modified:
6 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow a single translation to be from multiple differently-named sources BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=33255

Patch Set 1 #

Patch Set 2 : Re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -19 lines) Patch
M pkg/intl/lib/generate_localized.dart View 1 2 chunks +25 lines, -11 lines 0 comments Download
M pkg/intl/test/message_extraction/foo_messages_all.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/test/message_extraction/foo_messages_de_DE.dart View 4 chunks +6 lines, -0 lines 0 comments Download
M pkg/intl/test/message_extraction/foo_messages_fr.dart View 4 chunks +6 lines, -0 lines 0 comments Download
M pkg/intl/test/message_extraction/generate_from_json.dart View 3 chunks +7 lines, -6 lines 0 comments Download
M pkg/intl/test/message_extraction/make_hardcoded_translation.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/intl/test/message_extraction/sample_with_messages.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/intl/test/message_extraction/verify_messages.dart View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alan Knight
6 years, 9 months ago (2014-03-03 22:23:09 UTC) #1
Emily Fortuna
could you please re-upload? I got the ol' chunk mismatch error.
6 years, 9 months ago (2014-03-03 22:25:48 UTC) #2
Alan Knight
Re-uploaded.
6 years, 9 months ago (2014-03-03 23:11:00 UTC) #3
Emily Fortuna
lgtm
6 years, 9 months ago (2014-03-04 00:14:39 UTC) #4
Alan Knight
6 years, 9 months ago (2014-03-04 00:50:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r33255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698