Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 183763021: Don't match directly on gzip output of empty message, as it's not strictly specified. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't match directly on gzip output of empty message, as it's not strictly specified. Fixes test failure on Windows. BUG= R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=33211

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/standalone/io/zlib_test.dart View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
6 years, 9 months ago (2014-03-03 12:22:40 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/183763021/diff/1/tests/standalone/io/zlib_test.dart File tests/standalone/io/zlib_test.dart (right): https://codereview.chromium.org/183763021/diff/1/tests/standalone/io/zlib_test.dart#newcode51 tests/standalone/io/zlib_test.dart:51: Expect.isTrue(data.length > 0); Move where it belongs.
6 years, 9 months ago (2014-03-03 12:24:22 UTC) #2
Anders Johnsen
https://codereview.chromium.org/183763021/diff/1/tests/standalone/io/zlib_test.dart File tests/standalone/io/zlib_test.dart (right): https://codereview.chromium.org/183763021/diff/1/tests/standalone/io/zlib_test.dart#newcode51 tests/standalone/io/zlib_test.dart:51: Expect.isTrue(data.length > 0); On 2014/03/03 12:24:22, Lasse Reichstein Nielsen ...
6 years, 9 months ago (2014-03-03 12:24:59 UTC) #3
Anders Johnsen
https://codereview.chromium.org/183763021/diff/1/tests/standalone/io/zlib_test.dart File tests/standalone/io/zlib_test.dart (right): https://codereview.chromium.org/183763021/diff/1/tests/standalone/io/zlib_test.dart#newcode51 tests/standalone/io/zlib_test.dart:51: Expect.isTrue(data.length > 0); On 2014/03/03 12:24:22, Lasse Reichstein Nielsen ...
6 years, 9 months ago (2014-03-03 12:24:59 UTC) #4
Anders Johnsen
6 years, 9 months ago (2014-03-03 12:26:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r33211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698