Issue 183743031: Introduce constraints of deferred constants.

Issue 183743031: Introduce constraints of deferred constants. (Closed)

Created:
6 years, 9 months ago by sigurdm

Modified:
6 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Introduce constraints of deferred constants. Deferred classes can not be used in const new instance expressions. This CL depends on: https://codereview.chromium.org/177543002/ R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=33425

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -9 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View	1	3 chunks	+22 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/deferred_constraints_test.dart	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/language/language_analyzer2.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/183743031/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (right): https://codereview.chromium.org/183743031/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode760 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:760: compiler.reportFatalError( move on same line. https://codereview.chromium.org/183743031/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode788 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:788: compiler.terseDiagnostics); ...

6 years, 9 months ago (2014-03-06 15:32:58 UTC) #2

sigurdm

https://codereview.chromium.org/183743031/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (right): https://codereview.chromium.org/183743031/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode760 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:760: compiler.reportFatalError( On 2014/03/06 15:32:58, floitsch wrote: > move on ...

6 years, 9 months ago (2014-03-07 12:50:49 UTC) #3

sigurdm

Also changed MissingCompileTimeError to Fail in status-files. It seems dartium is not able to report ...

6 years, 9 months ago (2014-03-07 12:56:07 UTC) #4

sigurdm

6 years, 9 months ago (2014-03-07 13:11:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r33425 (presubmit successful).

Expand Messages | Collapse Messages