Issue 183683013: Change deoptimization description for materialized objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183683013: Change deoptimization description for materialized objects. (Closed)

Created:
6 years, 9 months ago by Florian Schneider

Modified:
6 years, 9 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change deoptimization description for materialized objects. Use field offset instead of fields as arguments in the deoptimization instructions for materialization of objects. This is to prepare for materializing contexts and fixed-size arrays when doing allocation sinking. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33267

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -9 lines)			Patch
M	runtime/vm/deferred_objects.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/deferred_objects.cc	View	1 chunk	+11 lines, -2 lines	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

6 years, 9 months ago (2014-03-04 11:53:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33267 (presubmit successful).

Expand Messages | Collapse Messages