Fix algorithm generics.

Fix algorithm generics.

Using "T extends Comparable" in these generics doesn't work, because we
want users to be able to pass in non-Comparable arguments with custom
comparator functions. Now if no explicit comparator is used, we rely on
runtime checks to ensure that the objects implement Comparable.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/collection/commit/f2c3ed7822ff17fa65dcc288b4de71ca185fbc4a

[Bob Nystrom, 2016-03-29 02:01:55]

A few style nits but LGTM.

https://codereview.chromium.org/1836163002/diff/1/lib/src/algorithms.dart
File lib/src/algorithms.dart (right):

https://codereview.chromium.org/1836163002/diff/1/lib/src/algorithms.dart#new...
lib/src/algorithms.dart:48: int lowerBound/*<T extends
Comparable<T>>*/(List/*<T>*/ sortedList, /*=T*/ value,
Long line.

https://codereview.chromium.org/1836163002/diff/1/lib/src/algorithms.dart#new...
lib/src/algorithms.dart:48: int lowerBound/*<T extends
Comparable<T>>*/(List/*<T>*/ sortedList, /*=T*/ value,
You probably want to remove the bound, right?

https://codereview.chromium.org/1836163002/diff/1/lib/src/algorithms.dart#new...
lib/src/algorithms.dart:114: int start: 0, int end: null}) {
": null" isn't needed.

https://codereview.chromium.org/1836163002/diff/1/lib/src/algorithms.dart#new...
lib/src/algorithms.dart:117: compare??= defaultCompare/*<T>*/();
Space before "??=".

https://codereview.chromium.org/1836163002/diff/1/lib/src/algorithms.dart#new...
lib/src/algorithms.dart:258: List/*<T>*/ target, int targetOffset) {
The indentation is kind of wacky here.

[nweiz, 2016-03-29 18:44:14]

Code review changes

[nweiz, 2016-03-29 18:47:23]

https://codereview.chromium.org/1836163002/diff/1/lib/src/algorithms.dart
File lib/src/algorithms.dart (right):

https://codereview.chromium.org/1836163002/diff/1/lib/src/algorithms.dart#new...
lib/src/algorithms.dart:48: int lowerBound/*<T extends
Comparable<T>>*/(List/*<T>*/ sortedList, /*=T*/ value,
On 2016/03/29 02:01:55, Bob Nystrom wrote:
> You probably want to remove the bound, right?

Ack, yes.

> Long line.

Done.

https://codereview.chromium.org/1836163002/diff/1/lib/src/algorithms.dart#new...
lib/src/algorithms.dart:114: int start: 0, int end: null}) {
On 2016/03/29 02:01:55, Bob Nystrom wrote:
> ": null" isn't needed.

Done.

https://codereview.chromium.org/1836163002/diff/1/lib/src/algorithms.dart#new...
lib/src/algorithms.dart:117: compare??= defaultCompare/*<T>*/();
On 2016/03/29 02:01:55, Bob Nystrom wrote:
> Space before "??=".

Done.

https://codereview.chromium.org/1836163002/diff/1/lib/src/algorithms.dart#new...
lib/src/algorithms.dart:258: List/*<T>*/ target, int targetOffset) {
On 2016/03/29 02:01:55, Bob Nystrom wrote:
> The indentation is kind of wacky here.

Done.

[nweiz, 2016-03-29 18:47:46]

Description was changed from

==========
Fix algorithm generics.

Using "T extends Comparable" in these generics doesn't work, because we
want users to be able to pass in non-Comparable arguments with custom
comparator functions. Now if no explicit comparator is used, we rely on
runtime checks to ensure that the objects implement Comparable.

R=rnystrom@google.com
==========

to

==========
Fix algorithm generics.

Using "T extends Comparable" in these generics doesn't work, because we
want users to be able to pass in non-Comparable arguments with custom
comparator functions. Now if no explicit comparator is used, we rely on
runtime checks to ensure that the objects implement Comparable.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/collection/commit/f2c3ed7822ff17fa65dcc288b4de71...
==========

[nweiz, 2016-03-29 18:47:48]

Committed patchset #2 (id:20001) manually as
f2c3ed7822ff17fa65dcc288b4de71ca185fbc4a (presubmit successful).