Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 18356011: Rename "pathos" package to "path". (Closed)

Created:
7 years, 5 months ago by Bob Nystrom
Modified:
7 years, 5 months ago
Reviewers:
nweiz, Anders Johnsen
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -3498 lines) Patch
M pkg/analyzer_experimental/lib/analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/services/runtime/coverage/coverage_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/lib/src/asset_id.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/test/asset_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/docgen/lib/docgen.dart View 24 chunks +127 lines, -127 lines 0 comments Download
M pkg/docgen/lib/src/io.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/docgen/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/multipart_file.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/test/multipart_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/date_symbol_data_file.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/generate_localized.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/src/file_data_reader.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/data_directory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/message_extraction/extract_to_json.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/message_extraction/generate_from_json.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/message_extraction/make_hardcoded_translation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/message_extraction/message_extraction_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/tool/generate_locale_data_files.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/path/README.md View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/path/lib/path.dart View 1 chunk +3 lines, -4 lines 0 comments Download
A + pkg/path/pubspec.yaml View 1 chunk +1 line, -4 lines 0 comments Download
A + pkg/path/test/dart2js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/path/test/dartium_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/path/test/io_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/path/test/path_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/path/test/posix_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/path/test/url_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/path/test/windows_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/pathos/README.md View 1 chunk +0 lines, -393 lines 0 comments Download
D pkg/pathos/lib/path.dart View 1 chunk +0 lines, -1141 lines 0 comments Download
D pkg/pathos/pubspec.yaml View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/pathos/test/pathos_dart2js_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/pathos/test/pathos_dartium_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D pkg/pathos/test/pathos_io_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D pkg/pathos/test/pathos_posix_test.dart View 1 chunk +0 lines, -424 lines 0 comments Download
D pkg/pathos/test/pathos_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/pathos/test/pathos_url_test.dart View 1 chunk +0 lines, -653 lines 0 comments Download
D pkg/pathos/test/pathos_windows_test.dart View 1 chunk +0 lines, -478 lines 0 comments Download
M pkg/pkg.status View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/scheduled_test/lib/descriptor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/nothing_descriptor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/pattern_descriptor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/descriptor/async_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/descriptor/directory_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/descriptor/file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/descriptor/nothing_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/descriptor/pattern_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/metatest.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/scheduled_process_test.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/stack_trace/lib/src/frame.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/stack_trace/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/stack_trace/test/frame_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/stack_trace/test/trace_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/stack_trace/test/vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/bin/dartdoc.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/lib/src/export_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/lib/universe_serializer.dart View 1 chunk +1 line, -1 line 2 comments Download
M sdk/lib/_internal/dartdoc/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/test/dartdoc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/test/export_map_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/bin/pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/deploy.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/lish.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/uploader.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/directory_tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/oauth2.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/package.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/pubspec.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/git.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/hosted.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/path.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/system_cache.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/directory.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/license.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/name.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/deploy/compiles_dart_entrypoints_to_dart_and_js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/deploy/copies_browser_js_next_to_entrypoints_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/deploy/copies_non_dart_files_to_deploy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/deploy/ignores_non_entrypoint_dart_files_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/deploy/reports_dart_parse_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/descriptor/git.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/descriptor/tar.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/dev_dependency_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/broken_symlink_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/git/lock_version_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/cached_pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/repair_cache_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/stay_locked_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/absolute_path_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/absolute_symlink_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/no_pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/nonexistent_dir_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/path_is_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/relative_path_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/relative_symlink_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/shared_dependency_symlink_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/shared_dependency_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/io_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/package_files_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/real_version_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/validator/dependency_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/validator/directory_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/validator/lib_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/validator/license_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/validator/name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/path.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_socket_renegotiate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/line_doc_comments.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/apidoc.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
I just did a straight rename of the package and fixed up the imports. I ...
7 years, 5 months ago (2013-07-12 16:51:52 UTC) #1
Anders Johnsen
LGTM! very nice :) https://codereview.chromium.org/18356011/diff/1/sdk/lib/_internal/dartdoc/lib/universe_serializer.dart File sdk/lib/_internal/dartdoc/lib/universe_serializer.dart (right): https://codereview.chromium.org/18356011/diff/1/sdk/lib/_internal/dartdoc/lib/universe_serializer.dart#newcode13 sdk/lib/_internal/dartdoc/lib/universe_serializer.dart:13: // TODO(rnystrom): Use "package:" URL ...
7 years, 5 months ago (2013-07-12 17:23:57 UTC) #2
Bob Nystrom
Committed patchset #1 manually as r24964 (presubmit successful).
7 years, 5 months ago (2013-07-12 17:55:45 UTC) #3
Bob Nystrom
7 years, 5 months ago (2013-07-12 17:59:39 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/18356011/diff/1/sdk/lib/_internal/dartdoc/lib...
File sdk/lib/_internal/dartdoc/lib/universe_serializer.dart (right):

https://codereview.chromium.org/18356011/diff/1/sdk/lib/_internal/dartdoc/lib...
sdk/lib/_internal/dartdoc/lib/universe_serializer.dart:13: // TODO(rnystrom):
Use "package:" URL (#4968).
On 2013/07/12 17:23:57, Anders Johnsen wrote:
> Remove this todo too?

I left it in because ideally those compiler imports would be package: too.
Though it's a moot point since dartdoc will hopefully be replaced by a new doc
tool soon anyway. :)

Powered by Google App Engine
This is Rietveld 408576698