Issue 18354007: initial commit of shadow_dom pkg

Issue 18354007: initial commit of shadow_dom pkg (Closed)

Created:
7 years, 5 months ago by Jennifer Messerly

Modified:
7 years, 5 months ago

Reviewers:
dgrove, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

initial commit of shadow_dom pkg R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=24890

Patch Set 1 #

Total comments: 9

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3332 lines, -0 lines)			Patch
A	pkg/shadow_dom/README.md	View	1 chunk	+100 lines, -0 lines	9 comments	Download
A	pkg/shadow_dom/lib/shadow_dom.debug.js	View	1 chunk	+3221 lines, -0 lines	0 comments	Download
A	pkg/shadow_dom/lib/shadow_dom.min.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	pkg/shadow_dom/pubspec.yaml	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

https://codereview.chromium.org/18354007/diff/1/pkg/shadow_dom/README.md File pkg/shadow_dom/README.md (right): https://codereview.chromium.org/18354007/diff/1/pkg/shadow_dom/README.md#newcode3 pkg/shadow_dom/README.md:3: Shadow DOM is designed to provide encapsulation by hiding ...

7 years, 5 months ago (2013-07-10 01:15:29 UTC) #1

Siggi Cherem (dart-lang)

lgtm! https://codereview.chromium.org/18354007/diff/1/pkg/shadow_dom/README.md File pkg/shadow_dom/README.md (right): https://codereview.chromium.org/18354007/diff/1/pkg/shadow_dom/README.md#newcode25 pkg/shadow_dom/README.md:25: Because it does extensive DOM patching, it should ...

7 years, 5 months ago (2013-07-10 15:45:08 UTC) #2

dgrove

https://codereview.chromium.org/18354007/diff/1/pkg/shadow_dom/README.md File pkg/shadow_dom/README.md (right): https://codereview.chromium.org/18354007/diff/1/pkg/shadow_dom/README.md#newcode13 pkg/shadow_dom/README.md:13: Include the polyfill in your HTML `<head>` to enable ...

7 years, 5 months ago (2013-07-10 20:04:32 UTC) #3

Jennifer Messerly

https://codereview.chromium.org/18354007/diff/1/pkg/shadow_dom/README.md File pkg/shadow_dom/README.md (right): https://codereview.chromium.org/18354007/diff/1/pkg/shadow_dom/README.md#newcode13 pkg/shadow_dom/README.md:13: Include the polyfill in your HTML `<head>` to enable ...

7 years, 5 months ago (2013-07-10 20:25:03 UTC) #4

Jennifer Messerly

7 years, 5 months ago (2013-07-10 21:52:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r24890 (presubmit successful).

Expand Messages | Collapse Messages