Issue 183513015: Move StackOverflow check after context chaining at function entry so that the context is properly s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183513015: Move StackOverflow check after context chaining at function entry so that the context is properly s… (Closed)

Created:
6 years, 9 months ago by srdjan

Modified:
6 years, 9 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Move StackOverflow check after context chaining at function entry so that the context is properly setup before stop at entry. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=33314

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -12 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View	1 2	2 chunks	+16 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

turnidge

lgtm. This is pretty similar to what I tried in my client. I saw a ...

6 years, 9 months ago (2014-03-04 23:55:38 UTC) #2

srdjan

6 years, 9 months ago (2014-03-05 00:10:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r33314 (presubmit successful).