Formatter re-think/updates.

Formatter re-think/updates.

A redesign striving for simplicity and a riff on ToSourceASTVisitor.  Some shuffling and renaming still to come.  Line and Token abstractions are also quite likely to change.  Consider this a baby-step.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24758

[scheglov, 2013-07-03 21:51:09]

lgtm

[Brian Wilkerson, 2013-07-03 22:03:02]

LGTM. I didn't look at every single visit method. Let me know if there are some
(beside visitBlock) that I really should have looked at.

https://codereview.chromium.org/18346013/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/18346013/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:149: writer = new
SourceWriter(initialIndent: options.initialIndentationLevel,
This seems weird. Why not just pass in the options object rather than some
subset of the options?

[pquitslund, 2013-07-03 22:21:39]

Thanks!

https://codereview.chromium.org/18346013/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/18346013/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:149: writer = new
SourceWriter(initialIndent: options.initialIndentationLevel,
On 2013/07/03 22:03:02, Brian Wilkerson wrote:
> This seems weird. Why not just pass in the options object rather than some
> subset of the options?

I was on the fence.  Leaning towards doing just that though.

[pquitslund, 2013-07-03 22:22:26]

Committed patchset #1 manually as r24758 (presubmit successful).