Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 18342003: Properly hiding import of deprecate from collection-dev. (Closed)

Created:
7 years, 5 months ago by blois
Modified:
7 years, 5 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, Anders Johnsen, floitsch
Visibility:
Public.

Description

Properly hiding import of deprecate from collection-dev. CL https://codereview.chromium.org//18692002 modified the generated files but missed the source files. Also skipped Dartium files which have the same conflicts. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=24814

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M sdk/lib/_collection_dev/iterable.dart View 1 1 chunk +12 lines, -4 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/svg_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/svg_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_audio_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_gl_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_sql_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 5 months ago (2013-07-08 18:30:40 UTC) #1
Emily Fortuna
lgtm
7 years, 5 months ago (2013-07-08 18:38:27 UTC) #2
blois
7 years, 5 months ago (2013-07-08 18:40:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r24814 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698