Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 18341023: Removes undefined shifting behavior from BitVector::Equals. (Closed)

Created:
7 years, 5 months ago by zra
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removes undefined shifting behavior from BitVector::Equals. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=24845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/bit_vector.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
7 years, 5 months ago (2013-07-09 00:32:19 UTC) #1
Vyacheslav Egorov (Google)
LGTM! Thanks
7 years, 5 months ago (2013-07-09 07:43:07 UTC) #2
zra
7 years, 5 months ago (2013-07-09 15:19:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24845 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698