Issue 183373003: Revert "Fix bad type-inferrence for logical expressions."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183373003: Revert "Fix bad type-inferrence for logical expressions." (Closed)

Created:
6 years, 9 months ago by floitsch

Modified:
6 years, 9 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Fix bad type-inferrence for logical expressions." This reverts commit r33120. Committed: https://code.google.com/p/dart/source/detail?r=33121

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -147 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart	View	3 chunks	+10 lines, -24 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_and_or_test.dart	View	3 chunks	+0 lines, -32 lines	0 comments	Download
D	tests/language/logical_expression2_test.dart	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	tests/language/logical_expression3_test.dart	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	tests/language/logical_expression4_test.dart	View	1 chunk	+0 lines, -29 lines	0 comments	Download

Total messages: 3 (0 generated)

floitsch

6 years, 9 months ago (2014-02-27 17:09:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33121 (presubmit successful).