added fail ok for docgen/test/single_library_test.dart

added fail ok for docgen/test/single_library_test.dart

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24816

[Emily Fortuna, 2013-07-08 19:42:27]

one adjustment, please

https://codereview.chromium.org/18337006/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/18337006/diff/1/pkg/pkg.status#newcode62
pkg/pkg.status:62: docgen/test/single_library_test: Fail, OK # Uses js_helper
Actually, let's set this to Skip instead of Fail, OK. We're skipping this
because it's not part of the VM checkout, so there's no need attempt to run it.

[janicejl, 2013-07-08 20:00:20]

https://codereview.chromium.org/18337006/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/18337006/diff/1/pkg/pkg.status#newcode62
pkg/pkg.status:62: docgen/test/single_library_test: Fail, OK # Uses js_helper
On 2013/07/08 19:42:27, Emily Fortuna wrote:
> Actually, let's set this to Skip instead of Fail, OK. We're skipping this
> because it's not part of the VM checkout, so there's no need attempt to run
it. 

Done.

[Emily Fortuna, 2013-07-08 20:03:17]

lgtm

[janicejl, 2013-07-08 20:12:06]

Committed patchset #2 manually as r24816 (presubmit successful).

[ahe, 2013-07-21 20:36:41]

https://codereview.chromium.org/18337006/diff/5001/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/18337006/diff/5001/pkg/pkg.status#newcode62
pkg/pkg.status:62: docgen/test/single_library_test: Skip # Uses js_helper
Something is wrong here.

This test imports dart:io.  This means that it can only work on the VM.

When this test is being run on dart2js, it only tests that dart2js can generate
code.  But the code dart2js generates is a no-op.  This is because dart2js
(during testing) is run with the option --enable-mock-compilation.

I think this test needs to pass on the VM.  Please file a bug against dart2js if
the source mirrors aren't working as you expect.  Johnni is on vacation right
now, but I'll do my best to help you solve this.