Issue 18324006: Extract the correct os-error on Socket.write, and report correctly in IOSink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18324006: Extract the correct os-error on Socket.write, and report correctly in IOSink. (Closed)

Created:
7 years, 5 months ago by Anders Johnsen

Modified:
7 years, 5 months ago

Reviewers:
ricow1, Bill Hesse, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Extract the correct os-error on Socket.write, and report correctly in IOSink. BUG= R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24623

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
	M	runtime/bin/socket.cc	View		2 chunks	+14 lines, -5 lines	0 comments	Download
	M	sdk/lib/io/io_sink.dart	View		3 chunks	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. https://codereview.chromium.org/18324006/diff/1/sdk/lib/io/io_sink.dart File sdk/lib/io/io_sink.dart (right): https://codereview.chromium.org/18324006/diff/1/sdk/lib/io/io_sink.dart#newcode126 sdk/lib/io/io_sink.dart:126: _hasError = true; Do you also want to ...

7 years, 5 months ago (2013-07-01 11:18:04 UTC) #2

Anders Johnsen

https://codereview.chromium.org/18324006/diff/1/sdk/lib/io/io_sink.dart File sdk/lib/io/io_sink.dart (right): https://codereview.chromium.org/18324006/diff/1/sdk/lib/io/io_sink.dart#newcode126 sdk/lib/io/io_sink.dart:126: _hasError = true; On 2013/07/01 11:18:05, Bill Hesse wrote: ...

7 years, 5 months ago (2013-07-01 11:18:57 UTC) #3

Anders Johnsen

7 years, 5 months ago (2013-07-01 11:34:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r24623 (presubmit successful).

Expand Messages | Collapse Messages