Optimize VM parsing of JSON String and number literals.

Optimize VM parsing of JSON String and number literals.

Extracted from https://codereview.chromium.org/181543004/

R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34297

[Lasse Reichstein Nielsen, 2014-03-07 10:40:27]

https://codereview.chromium.org/183193002/diff/20001/runtime/lib/convert_patc...
File runtime/lib/convert_patch.dart (right):

https://codereview.chromium.org/183193002/diff/20001/runtime/lib/convert_patc...
runtime/lib/convert_patch.dart:413: int parseStringWithEscapes(string, position)
{
string -> start.

[Lasse Reichstein Nielsen, 2014-03-14 09:59:39]

PTAL

[Lasse Reichstein Nielsen, 2014-03-24 08:30:53]

https://codereview.chromium.org/183193002/diff/20001/runtime/lib/convert_patc...
File runtime/lib/convert_patch.dart (right):

https://codereview.chromium.org/183193002/diff/20001/runtime/lib/convert_patc...
runtime/lib/convert_patch.dart:413: int parseStringWithEscapes(string, position)
{
string -> source even.

[Søren Gjesse, 2014-03-24 08:33:56]

LGTM, sorry for the delay

https://codereview.chromium.org/183193002/diff/20001/runtime/lib/convert_patc...
File runtime/lib/convert_patch.dart (right):

https://codereview.chromium.org/183193002/diff/20001/runtime/lib/convert_patc...
runtime/lib/convert_patch.dart:396: if (char <= BACKSLASH) {  // BACKSLASH is
larger than QUOTE.
and SPACE :-)

https://codereview.chromium.org/183193002/diff/20001/runtime/lib/convert_patc...
runtime/lib/convert_patch.dart:556:
listener.handleNumber(double.parse(literal));
There is no simpler way to create the double now you have disected all the
elements?

[Lasse Reichstein Nielsen, 2014-03-24 10:24:27]

Committed patchset #3 manually as r34297 (presubmit successful).

[Lasse Reichstein Nielsen, 2014-03-24 12:13:49]

https://codereview.chromium.org/183193002/diff/20001/runtime/lib/convert_patc...
File runtime/lib/convert_patch.dart (right):

https://codereview.chromium.org/183193002/diff/20001/runtime/lib/convert_patc...
runtime/lib/convert_patch.dart:396: if (char <= BACKSLASH) {  // BACKSLASH is
larger than QUOTE.
On 2014/03/24 08:33:57, Søren Gjesse wrote:
> and SPACE :-)

SPACE is *obviously* smaller than anything :)
But added to comment.

https://codereview.chromium.org/183193002/diff/20001/runtime/lib/convert_patc...
runtime/lib/convert_patch.dart:556:
listener.handleNumber(double.parse(literal));
In simple cases, there probably is.
Parsing a double is ... complex. It's easy to get it wrong.