Issue 183113005: Fix usage of heap_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183113005: Fix usage of heap_ (Closed)

Created:
6 years, 9 months ago by Cutch

Modified:
6 years, 9 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix usage of heap_ BUG= Committed: https://code.google.com/p/dart/source/detail?r=33124

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	runtime/vm/profiler.cc	View		4 chunks	+15 lines, -7 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

Committed patchset #1 manually as r33124 (presubmit successful).

6 years, 9 months ago (2014-02-27 18:07:25 UTC) #2

siva

6 years, 9 months ago (2014-02-27 18:30:48 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/183113005/diff/1/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/183113005/diff/1/runtime/vm/profiler.cc#newco...
runtime/vm/profiler.cc:892: #if defined(DEBUG_STACK_WALK)
I missed this in the last round, normally we don't do #defines like
this, I thought it was under #if defined(DEBUG) didn't realize
it was a different symbol.

Another question why does heap have to be an instance variable of
ProfilerSampleStackWalker why not just set a local variable
in walk and pass it down as an argument to VerifyCodeAddress.

Expand Messages | Collapse Messages