Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 1831103004: Fix strong mode warnings. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/collection@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : pubspec/changelog #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -53 lines) Patch
A .analysis_options View 1 1 chunk +2 lines, -0 lines 0 comments Download
M CHANGELOG.md View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/algorithms.dart View 3 chunks +6 lines, -3 lines 1 comment Download
M lib/src/canonicalized_map.dart View 5 chunks +9 lines, -5 lines 0 comments Download
M lib/src/equality.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M lib/src/iterable_zip.dart View 1 2 chunks +14 lines, -11 lines 0 comments Download
M lib/src/priority_queue.dart View 1 3 chunks +9 lines, -4 lines 0 comments Download
M lib/src/queue_list.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/unmodifiable_wrappers.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/src/wrappers.dart View 8 chunks +25 lines, -11 lines 0 comments Download
M pubspec.yaml View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/priority_queue_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/wrapper_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nweiz
4 years, 9 months ago (2016-03-24 22:20:20 UTC) #2
ochafik
Thanks for taking over, lgtm! I'll come back with a broader plan for the Travis ...
4 years, 9 months ago (2016-03-25 10:49:10 UTC) #4
Harry Terkelsen
lgtm Please submit ASAP, charted is blocked on this because DelegatingList map is not generic
4 years, 9 months ago (2016-03-25 23:20:18 UTC) #6
nweiz
Committed patchset #3 (id:40001) manually as 7ac6f9b3efd8db4fccdd45e7aeec0c1df1a884a2 (presubmit successful).
4 years, 9 months ago (2016-03-25 23:59:49 UTC) #8
abarth
https://codereview.chromium.org/1831103004/diff/40001/lib/src/algorithms.dart File lib/src/algorithms.dart (right): https://codereview.chromium.org/1831103004/diff/40001/lib/src/algorithms.dart#newcode84 lib/src/algorithms.dart:84: int lowerBound/*<T extends Comparable<T>>*/( This change isn't correct. The ...
4 years, 9 months ago (2016-03-26 07:13:23 UTC) #10
abarth
4 years, 9 months ago (2016-03-26 07:22:39 UTC) #11
Message was sent while issue was closed.
Fix in https://github.com/dart-lang/collection/pull/26.

Powered by Google App Engine
This is Rietveld 408576698