Add Digest.hashCode.

Add Digest.hashCode.

Closes #30

R=kevmoo@google.com

Committed: https://github.com/dart-lang/crypto/commit/493d76d50b16bc650fd972fe09b75244698fea57

[kevmoo, 2016-03-23 22:03:00]

lgtm

https://codereview.chromium.org/1830773003/diff/1/lib/src/digest.dart
File lib/src/digest.dart (right):

https://codereview.chromium.org/1830773003/diff/1/lib/src/digest.dart#newcode22
lib/src/digest.dart:22: var digest = other as Digest;
might could use ListEquality.equals here?

[nweiz, 2016-03-23 22:05:22]

https://codereview.chromium.org/1830773003/diff/1/lib/src/digest.dart
File lib/src/digest.dart (right):

https://codereview.chromium.org/1830773003/diff/1/lib/src/digest.dart#newcode22
lib/src/digest.dart:22: var digest = other as Digest;
On 2016/03/23 22:03:00, kevmoo wrote:
> might could use ListEquality.equals here?

I'm guessing the bitwise stuff is more efficient, since it takes advantage of
the fact that the list contains only bytes.

[nweiz, 2016-03-23 22:05:32]

Code review changes

[kevmoo, 2016-03-23 22:07:17]

https://codereview.chromium.org/1830773003/diff/1/lib/src/digest.dart
File lib/src/digest.dart (right):

https://codereview.chromium.org/1830773003/diff/1/lib/src/digest.dart#newcode22
lib/src/digest.dart:22: var digest = other as Digest;
On 2016/03/23 22:05:22, nweiz wrote:
> On 2016/03/23 22:03:00, kevmoo wrote:
> > might could use ListEquality.equals here?
> 
> I'm guessing the bitwise stuff is more efficient, since it takes advantage of
> the fact that the list contains only bytes.

Sure – then another thought: would it be good to short-circuit the comparison if
there is a diff before the end of the list?

[nweiz, 2016-03-23 22:11:16]

Description was changed from

==========
Add Digest.hashCode.

Closes #30

R=kevmoo@google.com
==========

to

==========
Add Digest.hashCode.

Closes #30

R=kevmoo@google.com

Committed:
https://github.com/dart-lang/crypto/commit/493d76d50b16bc650fd972fe09b7524469...
==========

[nweiz, 2016-03-23 22:11:17]

Committed patchset #2 (id:20001) manually as
493d76d50b16bc650fd972fe09b75244698fea57 (presubmit successful).

[nweiz, 2016-03-23 22:11:29]

https://codereview.chromium.org/1830773003/diff/1/lib/src/digest.dart
File lib/src/digest.dart (right):

https://codereview.chromium.org/1830773003/diff/1/lib/src/digest.dart#newcode22
lib/src/digest.dart:22: var digest = other as Digest;
On 2016/03/23 22:07:17, kevmoo wrote:
> On 2016/03/23 22:05:22, nweiz wrote:
> > On 2016/03/23 22:03:00, kevmoo wrote:
> > > might could use ListEquality.equals here?
> > 
> > I'm guessing the bitwise stuff is more efficient, since it takes advantage
of
> > the fact that the list contains only bytes.
> 
> Sure – then another thought: would it be good to short-circuit the
comparison if
> there is a diff before the end of the list?

On second thought, I will just switch to ListEquality. There's no reason to
believe that microefficiency is crucial here.

[kevmoo, 2016-03-23 22:14:02]

On 2016/03/23 22:11:29, nweiz wrote:
> https://codereview.chromium.org/1830773003/diff/1/lib/src/digest.dart
> File lib/src/digest.dart (right):
> 
>
https://codereview.chromium.org/1830773003/diff/1/lib/src/digest.dart#newcode22
> lib/src/digest.dart:22: var digest = other as Digest;
> On 2016/03/23 22:07:17, kevmoo wrote:
> > On 2016/03/23 22:05:22, nweiz wrote:
> > > On 2016/03/23 22:03:00, kevmoo wrote:
> > > > might could use ListEquality.equals here?
> > > 
> > > I'm guessing the bitwise stuff is more efficient, since it takes advantage
> of
> > > the fact that the list contains only bytes.
> > 
> > Sure – then another thought: would it be good to short-circuit the
> comparison if
> > there is a diff before the end of the list?
> 
> On second thought, I will just switch to ListEquality. There's no reason to
> believe that microefficiency is crucial here.

Agreed!