Issue 183013009: More fixes for compact_vm_config. The previous CL handled prints that occurred

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183013009: More fixes for compact_vm_config. The previous CL handled prints that occurred (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

More fixes for compact_vm_config. The previous CL handled prints that occurred when tests are passing, I didn't catch the print statements that occur on test failures. BUG= R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=33317

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
	M	pkg/unittest/lib/compact_vm_config.dart	View	1	4 chunks	+14 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion then LGTM! https://codereview.chromium.org/183013009/diff/1/pkg/unittest/lib/compact_vm_config.dart File pkg/unittest/lib/compact_vm_config.dart (right): https://codereview.chromium.org/183013009/diff/1/pkg/unittest/lib/compact_vm_config.dart#newcode204 pkg/unittest/lib/compact_vm_config.dart:204: _print([value = '']) => stdout.write('$value\n'); ...

6 years, 9 months ago (2014-03-05 01:36:08 UTC) #2

Siggi Cherem (dart-lang)

thanks! https://codereview.chromium.org/183013009/diff/1/pkg/unittest/lib/compact_vm_config.dart File pkg/unittest/lib/compact_vm_config.dart (right): https://codereview.chromium.org/183013009/diff/1/pkg/unittest/lib/compact_vm_config.dart#newcode204 pkg/unittest/lib/compact_vm_config.dart:204: _print([value = '']) => stdout.write('$value\n'); On 2014/03/05 01:36:08, ...

6 years, 9 months ago (2014-03-05 01:39:19 UTC) #3

Siggi Cherem (dart-lang)

6 years, 9 months ago (2014-03-05 01:41:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r33317 (presubmit successful).

Expand Messages | Collapse Messages