Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1829483002: Add support for a global configuration file. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for a global configuration file. Closes #63 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/27c7dd294a8751e19504405c1a2720140ec37c67

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -593 lines) Patch
M CHANGELOG.md View 2 chunks +7 lines, -0 lines 0 comments Download
A + doc/configuration.md View 13 chunks +45 lines, -1 line 0 comments Download
A doc/package_config.md View 1 chunk +0 lines, -531 lines 0 comments Download
A doc/package_config.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/executable.dart View 3 chunks +22 lines, -2 lines 0 comments Download
M lib/src/runner/configuration.dart View 1 chunk +5 lines, -1 line 0 comments Download
M lib/src/runner/configuration/load.dart View 10 chunks +108 lines, -57 lines 0 comments Download
A test/runner/configuration/global_test.dart View 1 1 chunk +128 lines, -0 lines 0 comments Download
M test/runner/configuration/top_level_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 9 months ago (2016-03-22 23:58:28 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1829483002/diff/1/test/runner/configuration/global_test.dart File test/runner/configuration/global_test.dart (right): https://codereview.chromium.org/1829483002/diff/1/test/runner/configuration/global_test.dart#newcode9 test/runner/configuration/global_test.dart:9: import 'package:path/path.dart' as p; unused https://codereview.chromium.org/1829483002/diff/1/test/runner/configuration/global_test.dart#newcode15 test/runner/configuration/global_test.dart:15: import ...
4 years, 9 months ago (2016-03-23 18:27:12 UTC) #2
nweiz
Code review changes
4 years, 9 months ago (2016-03-23 20:40:10 UTC) #3
nweiz
Committed patchset #2 (id:20001) manually as 27c7dd294a8751e19504405c1a2720140ec37c67 (presubmit successful).
4 years, 9 months ago (2016-03-23 20:40:51 UTC) #5
nweiz
4 years, 9 months ago (2016-03-23 20:41:19 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1829483002/diff/1/test/runner/configuration/g...
File test/runner/configuration/global_test.dart (right):

https://codereview.chromium.org/1829483002/diff/1/test/runner/configuration/g...
test/runner/configuration/global_test.dart:9: import 'package:path/path.dart' as
p;
On 2016/03/23 18:27:12, kevmoo wrote:
> unused

Done.

https://codereview.chromium.org/1829483002/diff/1/test/runner/configuration/g...
test/runner/configuration/global_test.dart:15: import
'package:test/src/util/io.dart';
On 2016/03/23 18:27:12, kevmoo wrote:
> unused

Done.

Powered by Google App Engine
This is Rietveld 408576698