Issue 18292003: Inline native setters for length and data in the optimizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18292003: Inline native setters for length and data in the optimizer. (Closed)

Created:
7 years, 5 months ago by Florian Schneider

Modified:
7 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Inline native setters for length and data in the optimizer. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=24801

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -6 lines)			Patch
M	runtime/lib/growable_array.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/18292003/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/18292003/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode1682 runtime/vm/flow_graph_optimizer.cc:1682: class_ids[0] == kGrowableObjectArrayCid) { Add parentheses

7 years, 5 months ago (2013-07-08 16:19:06 UTC) #2

Florian Schneider

https://codereview.chromium.org/18292003/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/18292003/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode1682 runtime/vm/flow_graph_optimizer.cc:1682: class_ids[0] == kGrowableObjectArrayCid) { On 2013/07/08 16:19:06, srdjan wrote: ...

7 years, 5 months ago (2013-07-08 16:24:58 UTC) #3

Florian Schneider

7 years, 5 months ago (2013-07-08 16:27:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24801 (presubmit successful).

Expand Messages | Collapse Messages

Issue 18292003: Inline native setters for length and data in the optimizer. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages