Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 182883002: - Sort out confusion between malloc/free and new/delete. (Closed)

Created:
6 years, 9 months ago by Ivan Posva
Modified:
6 years, 9 months ago
Reviewers:
zra, dgrove
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Sort out confusion between malloc/free and new/delete. Committed: https://code.google.com/p/dart/source/detail?r=33110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M runtime/vm/cpu_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/cpu_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/cpu_mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/cpu_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/cpuid.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/proccpuinfo.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
TBR
6 years, 9 months ago (2014-02-27 09:33:31 UTC) #1
Ivan Posva
Committed patchset #1 manually as r33110 (presubmit successful).
6 years, 9 months ago (2014-02-27 09:33:50 UTC) #2
zra
6 years, 9 months ago (2014-02-27 15:50:06 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698