Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 18272027: Add debugging info for 'this' (Closed)

Created:
7 years, 5 months ago by hausner
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add debugging info for 'this' Token range for 'this' was wrong in the debug info, so its value was not shown in most functions. Fixes issue 11435. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M runtime/vm/parser.cc View 11 chunks +13 lines, -14 lines 0 comments Download
M runtime/vm/scopes.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 5 months ago (2013-07-03 23:13:27 UTC) #1
regis
LGTM
7 years, 5 months ago (2013-07-03 23:20:11 UTC) #2
hausner
7 years, 5 months ago (2013-07-03 23:26:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24762 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698