Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 18271016: Don't assume that I can use package:-url in test. (Closed)

Created:
7 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 5 months ago
Reviewers:
dgrove, floitsch
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Don't assume that I can use package:-url in test. Committed: https://code.google.com/p/dart/source/detail?r=24839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/lib/async/stream_controller_async_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
TBR
7 years, 5 months ago (2013-07-09 11:25:11 UTC) #1
Lasse Reichstein Nielsen
Committed patchset #1 manually as r24839 (presubmit successful).
7 years, 5 months ago (2013-07-09 11:25:28 UTC) #2
floitsch
LGTM. although weird.
7 years, 5 months ago (2013-07-09 11:31:17 UTC) #3
dgrove
7 years, 5 months ago (2013-07-09 15:55:01 UTC) #4
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698