Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Issue 18268003: Take into account virtual devices (e.g. OpenVPN tun0) when iterating network (Closed)

Created:
7 years, 5 months ago by regis
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Take into account virtual devices (e.g. OpenVPN tun0) when iterating network interfaces. Their network address is NULL. Committed: https://code.google.com/p/dart/source/detail?r=24858

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M runtime/bin/socket_linux.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 5 months ago (2013-07-09 18:30:18 UTC) #1
regis
On 2013/07/09 18:30:18, regis wrote: Done in socket_macos.cc as well. Functionality missing in socket_android.cc. Not ...
7 years, 5 months ago (2013-07-09 18:42:37 UTC) #2
regis
7 years, 5 months ago (2013-07-09 18:42:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r24858 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698