Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1826543003: Update deprecations. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/crypto.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update deprecations. This deprecates: * Classes that used the wrong capitalization. * Base64 APIs, which are now available in the core libraries. * CryptoUtils, whose functionality is now available in the core libraries and the convert package. It also updates the deprecation message in already-deprecated APIs to correspond to only mention the version in which the APIs will be removed. The alternative APIs are mentioned in doc comments instead. R=rnystrom@google.com Committed: https://github.com/dart-lang/crypto/commit/72c74719a78cc5f4e162023ca5b17d3a53d3cd4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -114 lines) Patch
M CHANGELOG.md View 2 chunks +17 lines, -2 lines 0 comments Download
M lib/src/base64.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M lib/src/base64/decoder.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M lib/src/base64/decoder_sink.dart View 1 chunk +4 lines, -1 line 0 comments Download
M lib/src/base64/encoder.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M lib/src/base64/encoder_sink.dart View 1 chunk +4 lines, -1 line 0 comments Download
M lib/src/crypto_utils.dart View 2 chunks +9 lines, -21 lines 0 comments Download
M lib/src/digest.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/hash.dart View 1 chunk +11 lines, -10 lines 0 comments Download
M lib/src/hmac.dart View 4 chunks +30 lines, -38 lines 0 comments Download
M lib/src/md5.dart View 1 chunk +4 lines, -1 line 0 comments Download
M lib/src/sha1.dart View 2 chunks +20 lines, -14 lines 0 comments Download
M lib/src/sha256.dart View 4 chunks +20 lines, -11 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download
M test/hmac_md5_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/hmac_sha1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/hmac_sha256_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 9 months ago (2016-03-22 22:52:09 UTC) #1
Bob Nystrom
lgtm
4 years, 9 months ago (2016-03-22 23:35:24 UTC) #2
nweiz
4 years, 9 months ago (2016-03-22 23:47:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72c74719a78cc5f4e162023ca5b17d3a53d3cd4c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698