Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1826093002: Fix strong-mode warnings. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/source_maps@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
A .analysis_options View 1 1 chunk +2 lines, -0 lines 0 comments Download
M CHANGELOG.md View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M lib/parser.dart View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
nweiz
4 years, 9 months ago (2016-03-23 23:45:44 UTC) #2
nweiz
Code review changes
4 years, 9 months ago (2016-03-23 23:46:06 UTC) #3
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1826093002/diff/40001/lib/parser.dart File lib/parser.dart (right): https://codereview.chromium.org/1826093002/diff/40001/lib/parser.dart#newcode215 lib/parser.dart:215: urls = map['sources'] as List<String>, +leafp - would this ...
4 years, 9 months ago (2016-03-24 01:15:02 UTC) #5
Leaf
https://codereview.chromium.org/1826093002/diff/40001/lib/parser.dart File lib/parser.dart (right): https://codereview.chromium.org/1826093002/diff/40001/lib/parser.dart#newcode215 lib/parser.dart:215: urls = map['sources'] as List<String>, On 2016/03/24 01:15:02, Siggi ...
4 years, 9 months ago (2016-03-24 03:23:41 UTC) #6
nweiz
Code review changes
4 years, 9 months ago (2016-03-24 19:07:49 UTC) #7
nweiz
https://codereview.chromium.org/1826093002/diff/40001/lib/parser.dart File lib/parser.dart (right): https://codereview.chromium.org/1826093002/diff/40001/lib/parser.dart#newcode215 lib/parser.dart:215: urls = map['sources'] as List<String>, On 2016/03/24 01:15:02, Siggi ...
4 years, 9 months ago (2016-03-24 19:07:55 UTC) #8
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1826093002/diff/40001/lib/parser.dart File lib/parser.dart (right): https://codereview.chromium.org/1826093002/diff/40001/lib/parser.dart#newcode215 lib/parser.dart:215: urls = map['sources'] as List<String>, On 2016/03/24 19:07:54, ...
4 years, 9 months ago (2016-03-24 19:36:19 UTC) #9
nweiz
4 years, 9 months ago (2016-03-24 20:21:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
7e746054e75d4dbf53cd3c0498e6268244f3b765 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698