Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 182603003: Add TypeVariableMirror.isStatic to the API and dart2js. (Closed)

Created:
6 years, 9 months ago by rmacnak
Modified:
6 years, 9 months ago
Reviewers:
regis, gbracha
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add TypeVariableMirror.isStatic to the API. BUG=http://dartbug.com/16819 R=gbracha@google.com, regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=33283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/mirrors/mirrors_reader.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/lib/mirrors/type_variable_is_static_test.dart View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
6 years, 9 months ago (2014-03-04 01:12:12 UTC) #1
gbracha
API and tests lgtm
6 years, 9 months ago (2014-03-04 01:15:08 UTC) #2
regis
LGTM
6 years, 9 months ago (2014-03-04 17:28:26 UTC) #3
rmacnak
6 years, 9 months ago (2014-03-04 18:13:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r33283 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698