Avoid calling ByteData.setUint64.

Avoid calling ByteData.setUint64.

Closes #31

[nweiz, 2016-03-23 20:18:14]

nweiz@google.com changed reviewers:
+ kevmoo@google.com

[nweiz, 2016-03-23 20:18:14]

I'm branching this off of 0.9.2, and I'll merge it into 1.0.0 once that
releases.

[kevmoo, 2016-03-23 20:19:18]

lgtm

[nweiz, 2016-03-23 20:23:32]

Manually landed as
https://github.com/dart-lang/crypto/commit/8882b9d8bbb9df91d119c53f827ecf8968...

[nweiz, 2016-03-23 20:23:36]

Description was changed from

==========
Avoid calling ByteData.setUint64.

Closes #31
==========

to

==========
Avoid calling ByteData.setUint64.

Closes #31
==========

[sra1, 2016-03-23 22:15:50]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2016-03-23 22:15:50]

https://codereview.chromium.org/1825983002/diff/1/lib/src/hash_sink.dart
File lib/src/hash_sink.dart (right):

https://codereview.chromium.org/1825983002/diff/1/lib/src/hash_sink.dart#newc...
lib/src/hash_sink.dart:136: var highBits = lengthInBits >> 32;
This won't actually do what you want in dart2js.
dart2js bit operations assume the inputs are 32 bit unsigned values.
The result will always be zero.  It is probably always zero in practice.

You could use
 
   lengthInBits ~/ 4294967296

if you want it to work in JS for data of size 0.5GB.

[nweiz, 2016-03-23 22:21:26]

https://codereview.chromium.org/1825983002/diff/1/lib/src/hash_sink.dart
File lib/src/hash_sink.dart (right):

https://codereview.chromium.org/1825983002/diff/1/lib/src/hash_sink.dart#newc...
lib/src/hash_sink.dart:136: var highBits = lengthInBits >> 32;
On 2016/03/23 22:15:50, sra1 wrote:
> This won't actually do what you want in dart2js.
> dart2js bit operations assume the inputs are 32 bit unsigned values.
> The result will always be zero.  It is probably always zero in practice.
> 
> You could use
>  
>    lengthInBits ~/ 4294967296
> 
> if you want it to work in JS for data of size 0.5GB.

Presumably in dart2js, lengthInBits can't be higher than 2^32 anyway, right?