Introduce StackTraceOnThrowMixin.

Introduce StackTraceOnThrowMixin.

R=ahe@google.com, lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24951

[Lasse Reichstein Nielsen, 2013-07-12 13:00:51]

lgtm

https://codereview.chromium.org/18259021/diff/1/runtime/lib/errors_patch.dart
File runtime/lib/errors_patch.dart (right):

https://codereview.chromium.org/18259021/diff/1/runtime/lib/errors_patch.dart...
runtime/lib/errors_patch.dart:11: patch class StackTraceOnThrowMixin {
Pleeeeeeease consider dropping the "Mixin".

https://codereview.chromium.org/18259021/diff/1/sdk/lib/_internal/lib/core_pa...
File sdk/lib/_internal/lib/core_patch.dart (right):

https://codereview.chromium.org/18259021/diff/1/sdk/lib/_internal/lib/core_pa...
sdk/lib/_internal/lib/core_patch.dart:120: // TODO(11681): implement stackTrace
on Error.
on Error -> on thrown?

https://codereview.chromium.org/18259021/diff/1/sdk/lib/core/errors.dart
File sdk/lib/core/errors.dart (right):

https://codereview.chromium.org/18259021/diff/1/sdk/lib/core/errors.dart#newc...
sdk/lib/core/errors.dart:43: * Captures the stack trace when thrown.
Captures the current stack-trace when thrown.

Classes extending or mixing-in this class will automatically have a stack trace
captured the first time they are thrown. This stack trace is returned by the
[stackTrace] method.

Throwing the object again will not cause overwrite the first stack trace, so
objects that are `StackTraceOnThrowMixin` instances should not be reused.

https://codereview.chromium.org/18259021/diff/1/sdk/lib/core/errors.dart#newc...
sdk/lib/core/errors.dart:61: class TypeError extends AssertionError with
StackTraceOnThrowMixin {
Not necessary, it extends AssertionError.

[ahe, 2013-07-12 13:16:42]

LGTM!

[floitsch, 2013-07-12 15:30:13]

https://codereview.chromium.org/18259021/diff/1/runtime/lib/errors_patch.dart
File runtime/lib/errors_patch.dart (right):

https://codereview.chromium.org/18259021/diff/1/runtime/lib/errors_patch.dart...
runtime/lib/errors_patch.dart:11: patch class StackTraceOnThrowMixin {
On 2013/07/12 13:00:51, Lasse Reichstein Nielsen wrote:
> Pleeeeeeease consider dropping the "Mixin".

Done.

https://codereview.chromium.org/18259021/diff/1/sdk/lib/_internal/lib/core_pa...
File sdk/lib/_internal/lib/core_patch.dart (right):

https://codereview.chromium.org/18259021/diff/1/sdk/lib/_internal/lib/core_pa...
sdk/lib/_internal/lib/core_patch.dart:120: // TODO(11681): implement stackTrace
on Error.
On 2013/07/12 13:00:51, Lasse Reichstein Nielsen wrote:
> on Error -> on thrown?

Done.

https://codereview.chromium.org/18259021/diff/1/sdk/lib/core/errors.dart
File sdk/lib/core/errors.dart (right):

https://codereview.chromium.org/18259021/diff/1/sdk/lib/core/errors.dart#newc...
sdk/lib/core/errors.dart:43: * Captures the stack trace when thrown.
On 2013/07/12 13:00:51, Lasse Reichstein Nielsen wrote:
> Captures the current stack-trace when thrown.
> 
> Classes extending or mixing-in this class will automatically have a stack
trace
> captured the first time they are thrown. This stack trace is returned by the
> [stackTrace] method.
> 
> Throwing the object again will not cause overwrite the first stack trace, so
> objects that are `StackTraceOnThrowMixin` instances should not be reused.

Done.

https://codereview.chromium.org/18259021/diff/1/sdk/lib/core/errors.dart#newc...
sdk/lib/core/errors.dart:61: class TypeError extends AssertionError with
StackTraceOnThrowMixin {
On 2013/07/12 13:00:51, Lasse Reichstein Nielsen wrote:
> Not necessary, it extends AssertionError.

Done.

[floitsch, 2013-07-12 15:31:02]

Committed patchset #2 manually as r24951 (presubmit successful).