Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18255003: [package:mdv] fix error from dartanalyzer (Closed)

Created:
7 years, 5 months ago by Jennifer Messerly
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[package:mdv] fix error from dartanalyzer The ported code had a leftover "function() {". TBR=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=24668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/mdv/test/element_bindings_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
I'm not sure why it passed when I ran it, but it seems good to ...
7 years, 5 months ago (2013-07-01 22:51:07 UTC) #1
Jennifer Messerly
Committed patchset #1 manually as r24668 (presubmit successful).
7 years, 5 months ago (2013-07-01 22:51:22 UTC) #2
Siggi Cherem (dart-lang)
7 years, 5 months ago (2013-07-01 22:57:06 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698