used lookupInScope(name) to find the qualified names in comments.

used lookupInScope(name) to find the qualified names in comments.

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24883

[Tate Mandel, 2013-07-09 16:43:26]

https://codereview.chromium.org/18242010/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/18242010/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:278: // on scope once layout of viewer is finished.
Remove this TODO.

https://codereview.chromium.org/18242010/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:283: var libraryScope =
currentLibrary.lookupInScope(name);
I feel as though it should go the other way around. Don't you want to check
against the most specific member first and then check in a larger scope if it
returns null?

https://codereview.chromium.org/18242010/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:295: return new markdown.Element.text('code',
reference);
We probably don't want this as a <code> tag anymore. Maybe make it an <a> for
now since that's what all links are in the viewer at the moment.

[janicejl, 2013-07-09 19:49:21]

https://codereview.chromium.org/18242010/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/18242010/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:278: // on scope once layout of viewer is finished.
On 2013/07/09 16:43:26, Tate Mandel wrote:
> Remove this TODO.

Done.

https://codereview.chromium.org/18242010/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:283: var libraryScope =
currentLibrary.lookupInScope(name);
On 2013/07/09 16:43:26, Tate Mandel wrote:
> I feel as though it should go the other way around. Don't you want to check
> against the most specific member first and then check in a larger scope if it
> returns null? 

Done.

https://codereview.chromium.org/18242010/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:295: return new markdown.Element.text('code',
reference);
On 2013/07/09 16:43:26, Tate Mandel wrote:
> We probably don't want this as a <code> tag anymore. Maybe make it an <a> for
> now since that's what all links are in the viewer at the moment. 

Done.

[Emily Fortuna, 2013-07-09 20:21:35]

small tweaks, then lgtm

https://codereview.chromium.org/18242010/diff/7001/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/18242010/diff/7001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:63: * Returns 'true' if docgen sucessfuly completes.
I think you could use the backtick (`) instead, since it's a code value. so:
`true`

https://codereview.chromium.org/18242010/diff/7001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:275: * Converts all [_] references in comments to
<code>_</code>.
nit: can we change this comment to say "Converts all [foo] references in
comments to <code>foo</code>."  ? I originally read this comment as converting
the underscores to code and I was confused. :-)

[Emily Fortuna, 2013-07-09 20:22:06]

also if you can add some tests that exercise this that would be doubleplusgood!

[janicejl, 2013-07-10 01:16:40]

PTAL

I removed the if statement for trying to lookupinscope of a library, since
Johnni said that it is not possible to fix the reference of an library in
https://codereview.chromium.org/18323004/diff/17001/sdk/lib/_internal/compile...

https://codereview.chromium.org/18242010/diff/7001/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/18242010/diff/7001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:63: * Returns 'true' if docgen sucessfuly completes.
On 2013/07/09 20:21:36, Emily Fortuna wrote:
> I think you could use the backtick (`) instead, since it's a code value. so:
> `true`

Done.

https://codereview.chromium.org/18242010/diff/7001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:275: * Converts all [_] references in comments to
<code>_</code>.
On 2013/07/09 20:21:36, Emily Fortuna wrote:
> nit: can we change this comment to say "Converts all [foo] references in
> comments to <code>foo</code>."  ? I originally read this comment as converting
> the underscores to code and I was confused. :-)

Done.

[Emily Fortuna, 2013-07-10 17:18:46]

lgtm!

[janicejl, 2013-07-10 17:31:43]

Committed patchset #7 manually as r24883 (presubmit successful).