Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 18238010: Adjust list_pkg_directories to always have / slashes so that we don't accidentally create escape ch… (Closed)

Created:
7 years, 5 months ago by Emily Fortuna
Modified:
7 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adjust list_pkg_directories to always have / slashes so that we don't accidentally create escape characters on Windows. BUG= R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=24827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/list_pkg_directories.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
This is a silly change. The output of this script gets consumed by gyp, and ...
7 years, 5 months ago (2013-07-08 22:01:56 UTC) #1
Bob Nystrom
LGTM.
7 years, 5 months ago (2013-07-08 22:02:57 UTC) #2
Emily Fortuna
7 years, 5 months ago (2013-07-08 22:05:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24827 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698