Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 18237002: Failing gracefully (Closed)

Created:
7 years, 5 months ago by janicejl
Modified:
7 years, 5 months ago
Visibility:
Public.

Description

added a catch error to avoid printing a stack trace when it fails to create a mirror system. R=amouravski@google.com Committed: https://code.google.com/p/dart/source/detail?r=24650

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M pkg/docgen/lib/docgen.dart View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
janicejl
7 years, 5 months ago (2013-06-28 22:50:06 UTC) #1
Andrei Mouravski
https://codereview.chromium.org/18237002/diff/2001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/18237002/diff/2001/pkg/docgen/lib/docgen.dart#newcode189 pkg/docgen/lib/docgen.dart:189: exit(1); I think you can actually extract the stack ...
7 years, 5 months ago (2013-06-28 22:57:34 UTC) #2
janicejl
https://codereview.chromium.org/18237002/diff/2001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/18237002/diff/2001/pkg/docgen/lib/docgen.dart#newcode189 pkg/docgen/lib/docgen.dart:189: exit(1); On 2013/06/28 22:57:34, Andrei Mouravski wrote: > I ...
7 years, 5 months ago (2013-06-28 23:47:12 UTC) #3
Andrei Mouravski
lgtm
7 years, 5 months ago (2013-06-29 06:46:07 UTC) #4
janicejl
7 years, 5 months ago (2013-07-01 19:58:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r24650 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698