Issue 18234006: Fix bug 11637:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18234006: Fix bug 11637: (Closed)

Created:
7 years, 5 months ago by Ivan Posva

Modified:
7 years, 5 months ago

Reviewers:
rmacnak, hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug 11637: - Handle repeated private name mangling which can been introduced with mixins. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=24712

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -39 lines)			Patch
	M	runtime/vm/object.cc	View	1	2 chunks	+52 lines, -39 lines	2 comments	Download
	A	tests/language/private_mixin_exception_throw_test.dart	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Committed patchset #2 manually as r24712 (presubmit successful).

7 years, 5 months ago (2013-07-03 01:37:06 UTC) #3

hausner

7 years, 5 months ago (2013-07-03 16:24:58 UTC) #4

Message was sent while issue was closed.

DBC

https://codereview.chromium.org/18234006/diff/4001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/18234006/diff/4001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:231: i--;  // Account for for-loop increment.
DBC: Drop the 'for', just use 'while'. It's cleaner(tm).

https://codereview.chromium.org/18234006/diff/4001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:256: ASSERT(dot_pos == -1);  // Only one dot is supported.
What about the case of a qualified (imported) member name, e.g.
MyLib.MyClass.member?

Expand Messages | Collapse Messages