Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 18233004: Added a flag package-root for users to define where the package directory is. (Closed)

Created:
7 years, 5 months ago by janicejl
Modified:
7 years, 5 months ago
Visibility:
Public.

Description

Added a flag package-root for users to define where the package directory is. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=24647

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -83 lines) Patch
M pkg/docgen/bin/docgen.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/docgen/lib/docgen.dart View 1 3 chunks +17 lines, -6 lines 0 comments Download
D pkg/docgen/lib/src/dart2js_mirrors.dart View 1 chunk +0 lines, -77 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
janicejl
https://codereview.chromium.org/18233004/diff/1/pkg/docgen/lib/src/dart2js_mirrors.dart File pkg/docgen/lib/src/dart2js_mirrors.dart (left): https://codereview.chromium.org/18233004/diff/1/pkg/docgen/lib/src/dart2js_mirrors.dart#oldcode6 pkg/docgen/lib/src/dart2js_mirrors.dart:6: Removed this file because it is not used in ...
7 years, 5 months ago (2013-06-28 21:29:36 UTC) #1
Emily Fortuna
https://codereview.chromium.org/18233004/diff/1/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/18233004/diff/1/pkg/docgen/lib/docgen.dart#newcode122 pkg/docgen/lib/docgen.dart:122: // files with paths not containing '/packages' to avoid ...
7 years, 5 months ago (2013-07-01 18:51:57 UTC) #2
janicejl
https://codereview.chromium.org/18233004/diff/1/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/18233004/diff/1/pkg/docgen/lib/docgen.dart#newcode122 pkg/docgen/lib/docgen.dart:122: // files with paths not containing '/packages' to avoid ...
7 years, 5 months ago (2013-07-01 18:59:23 UTC) #3
Emily Fortuna
lgtm
7 years, 5 months ago (2013-07-01 19:00:34 UTC) #4
janicejl
7 years, 5 months ago (2013-07-01 19:43:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r24647 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698