Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 182313012: Split barback's transform_test into multiple smaller test files. (Closed)

Created:
6 years, 9 months ago by nweiz
Modified:
6 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Split barback's transform_test into multiple smaller test files. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33135

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1316 lines, -1277 lines) Patch
A pkg/barback/test/package_graph/transform/concurrency_test.dart View 1 1 chunk +473 lines, -0 lines 0 comments Download
A pkg/barback/test/package_graph/transform/cross_package_test.dart View 1 chunk +226 lines, -0 lines 0 comments Download
A pkg/barback/test/package_graph/transform/pass_through_test.dart View 1 chunk +273 lines, -0 lines 0 comments Download
A pkg/barback/test/package_graph/transform/transform_test.dart View 1 chunk +344 lines, -0 lines 0 comments Download
D pkg/barback/test/package_graph/transform_test.dart View 1 chunk +0 lines, -1277 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 9 months ago (2014-02-27 21:53:34 UTC) #1
Bob Nystrom
I assume the code is the same so I just skimmed. LGTM! https://codereview.chromium.org/182313012/diff/1/pkg/barback/test/package_graph/transform/concurrency_test.dart File pkg/barback/test/package_graph/transform/concurrency_test.dart ...
6 years, 9 months ago (2014-02-27 22:04:35 UTC) #2
nweiz
Yes, all the tests are the same, just reorganized. https://codereview.chromium.org/182313012/diff/1/pkg/barback/test/package_graph/transform/concurrency_test.dart File pkg/barback/test/package_graph/transform/concurrency_test.dart (right): https://codereview.chromium.org/182313012/diff/1/pkg/barback/test/package_graph/transform/concurrency_test.dart#newcode6 pkg/barback/test/package_graph/transform/concurrency_test.dart:6: ...
6 years, 9 months ago (2014-02-27 22:13:17 UTC) #3
nweiz
6 years, 9 months ago (2014-02-27 22:13:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r33135 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698