Inline context allocation in optimized code.

Inline context allocation in optimized code.

Instead of just calling the generic stub in optimized code, there is now
inlined code to handle allocation and initialization of the context. A
deferred code path handles inline allocation failure.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33203

[Florian Schneider, 2014-02-28 14:14:22]

This is ia32 only for now. It can be independently reviewed, landed and ported
to other archs since only arch-specific files are changed.

[regis, 2014-02-28 18:07:01]

LGTM with comments.

https://codereview.chromium.org/182303005/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/182303005/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:2267:
locs->set_out(Location::RegisterLocation(EAX));
Don't you miss a return locs here?

https://codereview.chromium.org/182303005/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:2317: __ movl(EBX,
Immediate(instance_size));
If you were using temp 2 instead of EBX directly, you would have noticed the
missing return :-)

https://codereview.chromium.org/182303005/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:2320: __ movl(EAX,
Address::Absolute(heap->TopAddress()));
ditto

https://codereview.chromium.org/182303005/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:2321: __ addl(EBX, EAX);
ditto

[Florian Schneider, 2014-03-03 10:25:06]

Committed patchset #2 manually as r33203 (presubmit successful).

[Florian Schneider, 2014-03-03 11:42:57]

https://codereview.chromium.org/182303005/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/182303005/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:2267:
locs->set_out(Location::RegisterLocation(EAX));
On 2014/02/28 18:07:01, regis wrote:
> Don't you miss a return locs here?

Thanks. Yes of course. That should improve the code. It did "by accident" since
the instructions is marked as call below. So all registers are available as
temps.

https://codereview.chromium.org/182303005/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:2317: __ movl(EBX,
Immediate(instance_size));
On 2014/02/28 18:07:01, regis wrote:
> If you were using temp 2 instead of EBX directly, you would have noticed the
> missing return :-)

Done. Changed to temp0, temp1, result, etc.

https://codereview.chromium.org/182303005/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:2320: __ movl(EAX,
Address::Absolute(heap->TopAddress()));
On 2014/02/28 18:07:01, regis wrote:
> ditto

Done.

https://codereview.chromium.org/182303005/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:2321: __ addl(EBX, EAX);
On 2014/02/28 18:07:01, regis wrote:
> ditto

Done.

[srdjan, 2014-03-03 18:30:08]

DBC

https://codereview.chromium.org/182303005/diff/10001/runtime/vm/assembler_ia3...
File runtime/vm/assembler_ia32.cc (right):

https://codereview.chromium.org/182303005/diff/10001/runtime/vm/assembler_ia3...
runtime/vm/assembler_ia32.cc:2355: 
Two lines between functions.

https://codereview.chromium.org/182303005/diff/10001/runtime/vm/assembler_ia32.h
File runtime/vm/assembler_ia32.h (right):

https://codereview.chromium.org/182303005/diff/10001/runtime/vm/assembler_ia3...
runtime/vm/assembler_ia32.h:778: Heap::Space space = Heap::kNew);
Can you use a different name. Register is almost an intptr_t.