Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1822373003: pkg/crypto: fix example (Closed)

Created:
4 years, 9 months ago by kevmoo
Modified:
4 years, 9 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/crypto.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M example/hash.dart View 1 2 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kevmoo
4 years, 9 months ago (2016-03-23 21:47:28 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1822373003/diff/1/example/hash.dart File example/hash.dart (right): https://codereview.chromium.org/1822373003/diff/1/example/hash.dart#newcode10 example/hash.dart:10: const _usage = 'Usage: dart hash.dart <md5|sha1|sha256> <input_filename>'; ...
4 years, 9 months ago (2016-03-23 22:28:35 UTC) #3
kevmoo
https://codereview.chromium.org/1822373003/diff/1/example/hash.dart File example/hash.dart (right): https://codereview.chromium.org/1822373003/diff/1/example/hash.dart#newcode10 example/hash.dart:10: const _usage = 'Usage: dart hash.dart <md5|sha1|sha256> <input_filename>'; On ...
4 years, 9 months ago (2016-03-23 22:49:05 UTC) #4
kevmoo
4 years, 9 months ago (2016-03-23 22:49:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
baf97b0f0844639637d5afa2b0c90f6f2ae73e80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698