Issue 18216002: Implement JsMethodMirror.constructorName.

Issue 18216002: Implement JsMethodMirror.constructorName. (Closed)

Created:
7 years, 5 months ago by ahe

Modified:
7 years, 5 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, kasperl, Johnni Winther, ngeoffray, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement JsMethodMirror.constructorName. BUG=http://dartbug.com/11608 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=24597

Patch Set 2 : Address comments #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	dart/tests/lib/mirrors/constructors_test.dart	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	dart/tests/lib/mirrors/stringify.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/18216002/diff/1/dart/tests/lib/mirrors/constructors_test.dart File dart/tests/lib/mirrors/constructors_test.dart (right): https://codereview.chromium.org/18216002/diff/1/dart/tests/lib/mirrors/constructors_test.dart#newcode65 dart/tests/lib/mirrors/constructors_test.dart:65: .toList()..sort()).toString()); As discussed offline, you could sort the ...

7 years, 5 months ago (2013-06-28 16:57:38 UTC) #2

ahe

Thank you, Martin! https://codereview.chromium.org/18216002/diff/1/dart/tests/lib/mirrors/constructors_test.dart File dart/tests/lib/mirrors/constructors_test.dart (right): https://codereview.chromium.org/18216002/diff/1/dart/tests/lib/mirrors/constructors_test.dart#newcode65 dart/tests/lib/mirrors/constructors_test.dart:65: .toList()..sort()).toString()); On 2013/06/28 16:57:38, kustermann wrote: ...

7 years, 5 months ago (2013-06-28 17:13:28 UTC) #3

ahe

7 years, 5 months ago (2013-06-28 17:13:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24597 (presubmit successful).

Expand Messages | Collapse Messages